-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add submodule Berlin #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome news @gislars !
Thanks a lot for your contribution (and the kind words).
Could you just remove the 2 timeout addition (see specific comments) ?
There is also the build:berlin
script missing in package.json
.
I use Netlify for the hosting. The free "package" is enough to run it !
Otherwise, you just have to run |
Thanks for your feedback. I removed the timeout settings and can confirm it is working locally. I wanted to stash the commits, but failed to do it. |
Have a look at my comment from this morning : #56 (comment) Ping me if you need more help ! |
I just discovered this repository this week. So I gave it a try and made a submodule for Berlin. It was straight forward, thanks for your good work!
Since I run into timeouts I had to update composer.json and overpass-way.php. The docs for GuzzleHttp mentions when no timeout is given, it'll wait until it finishes. But after 60-80 seconds a exception got raised. Adding the timeout parameter solved this problem.
I tried to put the final map online, but first I have to figure out how. Since I don't want to put it at $webroot, instead at example.org/equalstreetnames-berlin, I have to figure out how it works with nginx or if I have to configure the build somehow.
On the other hand, Berlin only have few name:etymology:wikidata tags, not much to see yet. But I hope this map will change it.