Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submodule Berlin #56

Merged
merged 8 commits into from
Jul 12, 2020
Merged

Add submodule Berlin #56

merged 8 commits into from
Jul 12, 2020

Conversation

gislars
Copy link
Contributor

@gislars gislars commented Jul 11, 2020

I just discovered this repository this week. So I gave it a try and made a submodule for Berlin. It was straight forward, thanks for your good work!
Since I run into timeouts I had to update composer.json and overpass-way.php. The docs for GuzzleHttp mentions when no timeout is given, it'll wait until it finishes. But after 60-80 seconds a exception got raised. Adding the timeout parameter solved this problem.

I tried to put the final map online, but first I have to figure out how. Since I don't want to put it at $webroot, instead at example.org/equalstreetnames-berlin, I have to figure out how it works with nginx or if I have to configure the build somehow.

On the other hand, Berlin only have few name:etymology:wikidata tags, not much to see yet. But I hope this map will change it.

Copy link
Member

@jbelien jbelien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome news @gislars !
Thanks a lot for your contribution (and the kind words).

Could you just remove the 2 timeout addition (see specific comments) ?
There is also the build:berlin script missing in package.json.

composer.json Outdated Show resolved Hide resolved
scripts/overpass-way.php Outdated Show resolved Hide resolved
@jbelien
Copy link
Member

jbelien commented Jul 12, 2020

I tried to put the final map online, but first I have to figure out how. Since I don't want to put it at $webroot, instead at example.org/equalstreetnames-berlin, I have to figure out how it works with nginx or if I have to configure the build somehow.

I use Netlify for the hosting. The free "package" is enough to run it !

  1. You connect your Netlify site to this repository (once this PR is merged)
  2. You set npm run build:berlin as build command
  3. You set dist/berlin as publish directory
  4. Enjoy the result ! 🤩

Otherwise, you just have to run npm run build:berlin on your server and then point example.org/equalstreetnames-berlin to the dist/berlin folder (or upload the content of dist/berlin on your server).
The content of dist/berlin are just static files.

@jbelien jbelien merged commit b7fb1c0 into EqualStreetNames:master Jul 12, 2020
@gislars
Copy link
Contributor Author

gislars commented Jul 12, 2020

Thanks for your feedback. I removed the timeout settings and can confirm it is working locally. I wanted to stash the commits, but failed to do it.
Next task for me: figure out how to bring it online.

@jbelien
Copy link
Member

jbelien commented Jul 12, 2020

Have a look at my comment from this morning : #56 (comment)

Ping me if you need more help !

@jbelien jbelien added the city New city added to the project label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
city New city added to the project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants