Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bad_words Issue:#246 #258

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

ujwal-narayan
Copy link
Contributor

Added support for bad_word_ids as discussed in Issue#246

  • Modified GENSettings to allow users to provide a list of bad words/phrases
  • Modified generate_text in happy-transformer/happy_generation.py
  • Added a test_case test_bad_words in tests/test_gen.py
  • Updated documentation and examples in docs/1-text-generation/3-settings.md

Copy link
Owner

@EricFillion EricFillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature! I really appreciate how you put in effort to write in-depth tests and to update the documentation. Here are some suggestions

docs/pages/1-text-generation/3-settings.md Outdated Show resolved Hide resolved
happytransformer/happy_generation.py Outdated Show resolved Hide resolved
happytransformer/happy_generation.py Show resolved Hide resolved
happytransformer/happy_generation.py Outdated Show resolved Hide resolved
tests/test_gen.py Outdated Show resolved Hide resolved
tests/test_gen.py Show resolved Hide resolved
docs/pages/1-text-generation/3-settings.md Show resolved Hide resolved
@ujwal-narayan
Copy link
Contributor Author

Thank you so much for your feedback! I've updated the pull request with the requested changes :)

@EricFillion
Copy link
Owner

Thanks for adding this feature! I'll create a new release within a week.

@EricFillion EricFillion merged commit f0b0595 into EricFillion:master Sep 2, 2021
@EricFillion EricFillion mentioned this pull request Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants