Add ability to use models from private repositories #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricFillion
approved these changes
Oct 29, 2021
Merged
|
Version 2.3.2 is live and contains these changes! Thanks for your help. |
|
Great thanks! |
|
Just noticed something isn't working right. Must have missed something when porting-back. Investigating now. Might be worth reverting unless I find a fix this morning on the train. |
|
Ok I found the problem, will issue a new PR to address it. Somehow forgot to include the init use_auth_token when porting the code over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction 🤞
Big fan of HappyTransformer, but I've noticed that we're lacking the ability to use private repositories. This pull-request implements the
use_auth_tokenwhich we use in our fork.I was considering simply adding a reference to
**kwargsand pass that to thefrom_pretrained(...)calls but decided against it.Documentation 📘
Every model's documentation has been updated to reflect the new API capability.
Backwards Compatibility 👀
The does not break API backwards compatibility 🙏
Further Discussions 💬
One thing I've noticed missing from HF is using an environment variable to pass the auth token instead of having it explicitly defined as part of the model calls.
This is something I'd like to explore and figure out if it's any interest to you. If so I'll take a stab. 🤷♂️