Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker images #249

Merged
merged 11 commits into from
Apr 29, 2024
Merged

Fix docker images #249

merged 11 commits into from
Apr 29, 2024

Conversation

LLukas22
Copy link
Contributor

Fixes #247

Since we now depend on pyo3 in core we need to include libpython in our runtime container.

Maybe we could put this pyo3 dependency behind a feature flag in the future, as it is currently necessary to have libpython available to compile/run the project even if mistralrs-pyo3 is excluded from the compilation.

Copy link

Code Metrics Report
  ───────────────────────────────────────────────────────────────────────────────
Language                 Files     Lines   Blanks  Comments     Code Complexity
───────────────────────────────────────────────────────────────────────────────
Rust                        70     23589     1555       510    21524       1309
───────────────────────────────────────────────────────────────────────────────
Total                       70     23589     1555       510    21524       1309
───────────────────────────────────────────────────────────────────────────────
Estimated Cost to Develop 77,898
Estimated Schedule Effort 11.864694 months
Estimated People Required 5.076026
───────────────────────────────────────────────────────────────────────────────
Processed 779680 bytes, 0.780 megabytes (SI)
───────────────────────────────────────────────────────────────────────────────
  

Copy link
Owner

@EricLBuehler EricLBuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great. I agree that we should try to make the pyo3 support in mistralrs-core a feature, I'll probably submit a PR.

@EricLBuehler EricLBuehler merged commit fa4209e into EricLBuehler:master Apr 29, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker builds fail with "failed to read /mistralrs/mistralrs-bench/Cargo.toml"
2 participants