-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker images #249
Merged
Merged
Fix docker images #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Metrics Report─────────────────────────────────────────────────────────────────────────────── Language Files Lines Blanks Comments Code Complexity ─────────────────────────────────────────────────────────────────────────────── Rust 70 23589 1555 510 21524 1309 ─────────────────────────────────────────────────────────────────────────────── Total 70 23589 1555 510 21524 1309 ─────────────────────────────────────────────────────────────────────────────── Estimated Cost to Develop 77,898 Estimated Schedule Effort 11.864694 months Estimated People Required 5.076026 ─────────────────────────────────────────────────────────────────────────────── Processed 779680 bytes, 0.780 megabytes (SI) ─────────────────────────────────────────────────────────────────────────────── |
EricLBuehler
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great. I agree that we should try to make the pyo3 support in mistralrs-core a feature, I'll probably submit a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247
Since we now depend on
pyo3
incore
we need to includelibpython
in our runtime container.Maybe we could put this
pyo3
dependency behind a feature flag in the future, as it is currently necessary to havelibpython
available to compile/run the project even ifmistralrs-pyo3
is excluded from the compilation.