Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Phi3 128k finally: use position ids to switch between short/long scaling #251

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

EricLBuehler
Copy link
Owner

Before, we used the start offset. This is not correct. Now, we use position ids based on the context length and past KV length.

Copy link

github-actions bot commented Apr 29, 2024

Code Metrics Report
  ───────────────────────────────────────────────────────────────────────────────
Language                 Files     Lines   Blanks  Comments     Code Complexity
───────────────────────────────────────────────────────────────────────────────
Rust                        70     23594     1555       510    21529       1309
───────────────────────────────────────────────────────────────────────────────
Total                       70     23594     1555       510    21529       1309
───────────────────────────────────────────────────────────────────────────────
Estimated Cost to Develop 78,063
Estimated Schedule Effort 11.865794 months
Estimated People Required 5.076793
───────────────────────────────────────────────────────────────────────────────
Processed 780091 bytes, 0.780 megabytes (SI)
───────────────────────────────────────────────────────────────────────────────
  

@EricLBuehler EricLBuehler merged commit 097ac3d into master Apr 29, 2024
11 checks passed
@EricLBuehler EricLBuehler deleted the phi3_position_ids branch April 29, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant