Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid types definition #200

Closed
6utt3rfly opened this issue Nov 26, 2021 · 2 comments · Fixed by #202
Closed

Invalid types definition #200

6utt3rfly opened this issue Nov 26, 2021 · 2 comments · Fixed by #202
Assignees
@6utt3rfly
Labels
bug released on @beta released

Comments

@6utt3rfly
Copy link
Collaborator

From @pchaneyo 's comment on a previous commit

node_modules/jsep/typings/tsd.d.ts:56:4 - error TS2411: Property 'optional'
  of type 'boolean | undefined' is not assignable to 'string' index type
  'baseTypes | Expression | (baseTypes | Expression)[]'.

56 optional?: boolean;`
@6utt3rfly 6utt3rfly added the bug label Nov 26, 2021
@6utt3rfly 6utt3rfly self-assigned this Nov 26, 2021
@6utt3rfly 6utt3rfly mentioned this issue Nov 26, 2021
Merged
6utt3rfly referenced this issue Nov 26, 2021
@6utt3rfly
fix: add missing optional property to types
e2f758e 
(was missing from #185)
github-actions bot pushed a commit that referenced this issue Dec 13, 2021
@semantic-release-bot
build: 1.3.0-beta.1 [skip ci]
65c363d 
# [1.3.0-beta.1](v1.2.0...v1.3.0-beta.1) (2021-12-13)

### Bug Fixes

* types for optional member expression now in generic baseType ([79fb0dc](79fb0dc)), closes [#200](#200)

### Features

* assignment right-to-left and precedence with ternary ([e5652eb](e5652eb)), closes [#189](#189)
* simplify ternary since to stop handling ':' binary operator ([4196623](4196623))
@github-actions
Copy link

🎉 This issue has been resolved in version 1.3.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Feb 28, 2022
@semantic-release-bot
build: 1.3.0 [skip ci]
e35fb41 
# [1.3.0](v1.2.0...v1.3.0) (2022-02-28)

### Bug Fixes

* types for optional member expression now in generic baseType ([79fb0dc](79fb0dc)), closes [#200](#200)

### Features

* assignment right-to-left and precedence with ternary ([e5652eb](e5652eb)), closes [#189](#189)
* simplify ternary since to stop handling ':' binary operator ([4196623](4196623))
@github-actions
Copy link

🎉 This issue has been resolved in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@6utt3rfly 6utt3rfly

Labels
bug released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: types for optional member expression now in generic baseType EricSmekens/jsep
1 participant
@6utt3rfly