-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jsep.version returns "1.0.2" instead of 1.2.0 or 1.3.0 #216
Comments
- adds NEXT_VERSION env variable to the rollup - builds the package as part of semantic-release so that it can utilize the new version in the build - commit to git after npm so that git contains the updated package.json file fixes #216
## [1.3.4](v1.3.3...v1.3.4) (2022-03-22) ### Bug Fixes * embed correct version into builds ([9e90f3d](9e90f3d)), closes [#216](#216)
🎉 This issue has been resolved in version 1.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [@jsep-plugin/arrow-v1.0.4](https://github.com/EricSmekens/jsep/compare/@jsep-plugin/arrow-v1.0.3...@jsep-plugin/arrow-v1.0.4) (2022-03-22) ### Bug Fixes * embed correct version into builds ([9e90f3d](9e90f3d)), closes [#216](#216)
🎉 This issue has been resolved in version @jsep-plugin/arrow-v1.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [@jsep-plugin/ternary-v1.1.2](https://github.com/EricSmekens/jsep/compare/@jsep-plugin/ternary-v1.1.1...@jsep-plugin/ternary-v1.1.2) (2022-03-22) ### Bug Fixes * embed correct version into builds ([9e90f3d](9e90f3d)), closes [#216](#216)
🎉 This issue has been resolved in version @jsep-plugin/ternary-v1.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@adicrl - thank you for reporting! I've published 1.3.4 which now has the correct version in the bundled package.json and embedded into jsep. I had to swap the build steps to commit to git after npm, and I had to incorporate the build into semantic-release to embed the version. (NOTE: I accidentally made some commits that I thought were going to my fork but weren't 😬 Sorry about that!) |
Wow, I merely pressed the submit button the other day and you already released a new build! 🏆🏆🏆 |
The package version does not match the distributed files.
On GitHub:
package.json
declares the version "1.0.2":src/json.js
mentions that the version will get replaced to the correct value:In the distribution package of 1.3.0:
package/package.json
declares the version "1.3.0":Actual:
dist/json.js
is hardcoded to "1.0.2":Expected:
dist/json.js
should match thepackage/package.json
version.File links:
https://github.com/EricSmekens/jsep/blob/master/package.json
https://github.com/EricSmekens/jsep/blob/master/src/jsep.js
https://github.com/EricSmekens/jsep/releases/tag/v1.3.0 (see Assets)
The text was updated successfully, but these errors were encountered: