Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite to ESM, simplify build process (npm scripts instead of Grunt) #132

Merged
merged 5 commits into from
Apr 3, 2021
Merged

Rewrite to ESM, simplify build process (npm scripts instead of Grunt) #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5458a9e
Rewrite to ESM
LeaVerou Apr 1, 2021
d0fc78a
Add rollup to bundle, minify, replace version
LeaVerou Apr 2, 2021
9ee4c05
Add script for npm run test
LeaVerou Apr 2, 2021
78ab3a1
Docco
LeaVerou Apr 2, 2021
366e8f2
Add default task, as CI expects it
LeaVerou Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ annotated_source/


#Build files
[Bb]uild/
[Bb]uild/
dist/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeaVerou - I wonder if the build should be moved back to the build folder (instead of dist) for better compatibility with existing versions? (Could be part of #152 ). I just saw a comment in donmccurdy/expression-eval#41 that made me wonder

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dist is convention though.
What if we add a file to build that prints out something like "JSEP has moved to using dist instead of build. Please use dist instead"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we could probably just note it in the changelog?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely note it in the changelog!

Loading