Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin system #142

Merged
merged 8 commits into from
Jun 5, 2021
Merged

Plugin system #142

merged 8 commits into from
Jun 5, 2021

Commits on May 2, 2021

  1. Configuration menu
    Copy the full SHA
    3ffc3a1 View commit details
    Browse the repository at this point in the history
  2. Plugin System:

    - move utilities from tests.js to test_utils.js
    - added hooks class + tests
    - Added hooks to JSEP + tests for their arbitrary usage
    - Moved Ternary to a plugin. Default JSEP still includes ternary support.
    6utt3rfly committed May 2, 2021
    Configuration menu
    Copy the full SHA
    ce3134c View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. Plugin update

    - switch from `this.node` to local method object `env.node`
    - make after-all hook use env.node instead of nodes
    - Update readme
    6utt3rfly committed May 5, 2021
    Configuration menu
    Copy the full SHA
    3602893 View commit details
    Browse the repository at this point in the history
  2. Add .editorconfig to set tabs (not spaces)

    add lint rule for tabs
    update all spaces to tabs to pass lint
    6utt3rfly committed May 5, 2021
    Configuration menu
    Copy the full SHA
    7bbdd2d View commit details
    Browse the repository at this point in the history
  3. Merge branch 'commonjs' into plugin-system

    # Conflicts:
    #	rollup.config.js
    #	src/jsep.js
    #	test/tests.js
    6utt3rfly committed May 5, 2021
    Configuration menu
    Copy the full SHA
    9e88f5f View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. Configuration menu
    Copy the full SHA
    7fdd5dc View commit details
    Browse the repository at this point in the history

Commits on May 23, 2021

  1. Speed-optimization for new plugin hooks calling

    - add Jsep.hooksAdd() shortcut to Jsep.hooks.add()
    - pre-compute the calls to all registered hooks, binding to this from the constructor. Wrap the object-handling of the node argument into the hooks and return the result. This changes `Jsep.hooks.run('name', { context: this, node: {} })` to `updatedNode = this['name'](node)'`
    - remove `before-all` and `after-all` hooks
    - updated tsd.d.ts (including spacing)
    6utt3rfly committed May 23, 2021
    Configuration menu
    Copy the full SHA
    3ea21e0 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Revert some of previous commit to update calls to run hooks:

    - Remove pre-compute optimization, but add local method this.runHook(name, node). This will check if there is a hook to run before calling hooks.run() in order to save time. Performance is around 89% of the code without hooks (but without the optimization was around 67% - mostly due to making the { context: this, node } object)
    6utt3rfly committed May 25, 2021
    Configuration menu
    Copy the full SHA
    cca75e5 View commit details
    Browse the repository at this point in the history