-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin system #142
Merged
Merged
Plugin system #142
Commits on May 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3ffc3a1 - Browse repository at this point
Copy the full SHA 3ffc3a1View commit details -
- move utilities from tests.js to test_utils.js - added hooks class + tests - Added hooks to JSEP + tests for their arbitrary usage - Moved Ternary to a plugin. Default JSEP still includes ternary support.
Configuration menu - View commit details
-
Copy full SHA for ce3134c - Browse repository at this point
Copy the full SHA ce3134cView commit details
Commits on May 5, 2021
-
- switch from `this.node` to local method object `env.node` - make after-all hook use env.node instead of nodes - Update readme
Configuration menu - View commit details
-
Copy full SHA for 3602893 - Browse repository at this point
Copy the full SHA 3602893View commit details -
Add .editorconfig to set tabs (not spaces)
add lint rule for tabs update all spaces to tabs to pass lint
Configuration menu - View commit details
-
Copy full SHA for 7bbdd2d - Browse repository at this point
Copy the full SHA 7bbdd2dView commit details -
Merge branch 'commonjs' into plugin-system
# Conflicts: # rollup.config.js # src/jsep.js # test/tests.js
Configuration menu - View commit details
-
Copy full SHA for 9e88f5f - Browse repository at this point
Copy the full SHA 9e88f5fView commit details
Commits on May 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7fdd5dc - Browse repository at this point
Copy the full SHA 7fdd5dcView commit details
Commits on May 23, 2021
-
Speed-optimization for new plugin hooks calling
- add Jsep.hooksAdd() shortcut to Jsep.hooks.add() - pre-compute the calls to all registered hooks, binding to this from the constructor. Wrap the object-handling of the node argument into the hooks and return the result. This changes `Jsep.hooks.run('name', { context: this, node: {} })` to `updatedNode = this['name'](node)'` - remove `before-all` and `after-all` hooks - updated tsd.d.ts (including spacing)
Configuration menu - View commit details
-
Copy full SHA for 3ea21e0 - Browse repository at this point
Copy the full SHA 3ea21e0View commit details
Commits on May 25, 2021
-
Revert some of previous commit to update calls to run hooks:
- Remove pre-compute optimization, but add local method this.runHook(name, node). This will check if there is a hook to run before calling hooks.run() in order to save time. Performance is around 89% of the code without hooks (but without the optimization was around 67% - mostly due to making the { context: this, node } object)
Configuration menu - View commit details
-
Copy full SHA for cca75e5 - Browse repository at this point
Copy the full SHA cca75e5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.