-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unary operator fixes #27
Conversation
- ajout des rubriques "Accélération", "Force", "Pression", "Puissance", "Vitesse" et mise à jour de certaines autres rubriques - renvoi vers la page Wikipedia des conversions en ne précisant que l'unité (par exemple convertir("radian")) - ajout de noms secondaires pour les unités (par exemple masse atomique = dalton = Da = u = uma) - intégration d'une [pull request](EricSmekens/jsep#23) pour personnaliser les "literals" (pi par exemple) - intégration d'une [pull request](EricSmekens/jsep#27) pour corriger les opérateurs unaires - intégration d'une [pull request](EricSmekens/jsep#17) pour permettre de saisir des nombres en héxa (0x12 par exemple) - sur le même principe, permettre de saisir des nombres en binaire (0b1100 = 12 par exemple) ou en octal (0o12 = 10 par exemple)
@EricSmekens What is wrong with this one and it hasn't been merged? Can I help? |
@LeaVerou, I was first focussing on low-impact merges to get a release version out soon. You can always help by checking/testing PR's and confirm them. Makes it more confident for me to merge them, as I cannot completely oversee the impact on jsep yet. |
I will check the backslashes soon, if it matches esprima's output or what we can do about that. |
@EricSmekens I have pulled this locally, resolved conflicts, and tested it. Both the jsep testsuite pass, and my own testsuite for Mavo's expression parsing (which uses jsep). Should I merge or do you want to do any more checks? |
I'm fine with merging this! :) |
Yay, merged! |
Uh-oh, I just realized this causes a pretty serious bug. > jsep.addUnaryOp("not");
> jsep("notes")
< {type: "UnaryExpression", operator: "not", argument: {…}, prefix: true} Damn. Looking into it. |
Fixes #26