Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocumentAssembler: Support for images #30

Open
wants to merge 8 commits into
base: vNext
Choose a base branch
from
Open

DocumentAssembler: Support for images #30

wants to merge 8 commits into from

Commits on Dec 17, 2020

  1. DocumentAssembler: Support for Images 

    Added ability to embed image content in template. Input image can be supplied either as a base64 encoded string or as a path to file. Supports different layout options. For different samples, see unit tests.
    @krembf @carzaza
    krembf authored and carzaza committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    31cd7e5 View commit details
    Browse the repository at this point in the history

  2. DocumentAssembler: Support for Images 

    Removed unused "Aspect" attribute
    @krembf @carzaza
    krembf authored and carzaza committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    43d0658 View commit details
    Browse the repository at this point in the history

  3. Fix for case with extra character before Image Content Control 

    It is expected that Image Content Control will immediately follow ImageSelect element, thus containing paragraph as child element. There is a situation where some extra characters apppear before the Image Content Control thus causing a situation where Image Conent Control is inside the paragraph and not vise versa, as expected. In such case, the system should trigger an error.
- Added handling of the situation decrribed above
- Added unit test to verify proper behavior
    @krembf @carzaza
    krembf authored and carzaza committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    cd67c09 View commit details
    Browse the repository at this point in the history

  4. Added support for image select in header and footer 

    - Added ability to use image content control inside header and footer
- Added unit tests to verify proper behavior
    @krembf @carzaza
    krembf authored and carzaza committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    4f0497b View commit details
    Browse the repository at this point in the history

  5. Fixed image content improperly working with # notation 

    Modified document assembler to support # notation.
Added unit tests to verify proprer behavior. Tests which are having A suffix (e.g. DA270A-ImageSelect.docx) are duplicates of the original ones, but with # notation used instead.
    @krembf @carzaza
    krembf authored and carzaza committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    b24e7e2 View commit details
    Browse the repository at this point in the history

  6. Removed static class variable _docPrId for thread-safety 

    Removed static variable _docPrId. Now updating images docPr ids at the end of the processing and not during the transform.
    @krembf @carzaza
    krembf authored and carzaza committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    0a56e1f View commit details
    Browse the repository at this point in the history

  7. Corrected relative paths for image files

    @krembf @carzaza
    krembf authored and carzaza committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    2f98a2c View commit details
    Browse the repository at this point in the history

  8. Corrected relative paths for image files

    @krembf @carzaza
    krembf authored and carzaza committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    e0f7a89 View commit details
    Browse the repository at this point in the history