DocumentAssembler: Support for images #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ability to embed image content in template. Input image can be supplied either as a base64 encoded string or as a path to file. Supports different layout options. For different samples, see unit tests.
Removed unused "Aspect" attribute
It is expected that Image Content Control will immediately follow ImageSelect element, thus containing paragraph as child element. There is a situation where some extra characters apppear before the Image Content Control thus causing a situation where Image Conent Control is inside the paragraph and not vise versa, as expected. In such case, the system should trigger an error. - Added handling of the situation decrribed above - Added unit test to verify proper behavior
- Added ability to use image content control inside header and footer - Added unit tests to verify proper behavior
Modified document assembler to support # notation. Added unit tests to verify proprer behavior. Tests which are having A suffix (e.g. DA270A-ImageSelect.docx) are duplicates of the original ones, but with # notation used instead.
Removed static variable _docPrId. Now updating images docPr ids at the end of the processing and not during the transform.
|
¿Any news related with this Pull Request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a copy of the closed one in the original OfficeDev repository from @krembf (see PR#236).
This feature is important for us to be available as we are currently using a copy of that PR.