Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New maps #3

Merged
merged 1 commit into from
Apr 30, 2019
Merged

New maps #3

merged 1 commit into from
Apr 30, 2019

Conversation

barrie0482
Copy link
Contributor

Hi Eric,

This is my first lot of maps. These events I use in my timelines at work.

Cheers, Barrie

@EricZimmerman
Copy link
Owner

Why not combine the domain and user so its presented in a more compact form and in a way that most people are used to seeing?

rather than have

Domain: Zim
User: Eric

just do

Zim\Eric

thoughts?

these look great otherwise

@EricZimmerman
Copy link
Owner

also for EventId: 6005 and the other one referencing Computer, that field is already automatically pulled into the CSV so this is redundant. i would drop these two UNLESS you like having the Map description column populated (which is nice).

thoughts on this one?

@EricZimmerman
Copy link
Owner

im going to pull these in and then combine the domain and username, like the 4624 map.

@EricZimmerman EricZimmerman merged commit bfc0b77 into EricZimmerman:master Apr 30, 2019
@EricZimmerman
Copy link
Owner

pulled, updated, and committed the changes. refresh from here for current

@EricZimmerman
Copy link
Owner

and thanks!! great work

@barrie0482
Copy link
Contributor Author

barrie0482 commented Apr 30, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants