[make] Install common requirements on venv_dev target #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
reviewed
Nov 12, 2021
| @@ -112,7 +112,8 @@ clean_venv: | |||
| rm -rf venv | |||
|
|
|||
| PIP_DEV_DEPS_CMD = make -C $(CC_ANALYZER) pip_dev_deps && \ | |||
| make -C $(CC_WEB) pip_dev_deps | |||
| make -C $(CC_WEB) pip_dev_deps && \ | |||
There was a problem hiding this comment.
This line has two spaces indentation. Does it work like that?
There was a problem hiding this comment.
I tried it, it worked for me but I fixed it.
csordasmarton
force-pushed
the
venv_dev_install_common_requirements
branch
from
0fd3bb8
to
0586180
Compare
bruntib
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.