[cli] Fix link in gerrit output #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
added
CLI 💻
If `CC_REPORT_URL` is defined and `gerrit` format is used at `CodeChecker parse` or `CodeChecker cmd diff` commands, the output will contain the value of this environment variable wrapped inside quotes. When this output is sent to gerrit, it will convert URL links to HTML `a` tags. Unfortunately gerrit will think that the ending quote is part of the URL, so it will not remove it. This way the URL will be invalid. To solve this problem in this patch we will remove the quotes around the URL link.
csordasmarton
force-pushed
the
fix_link_in_gerrit_output
branch
from
e7e428b
to
8f9e2e8
Compare
bruntib
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
CC_REPORT_URLis defined andgerritformat is used atCodeChecker parseor
CodeChecker cmd diffcommands, the output will contain the value of thisenvironment variable wrapped inside quotes. When this output is sent to gerrit,
it will convert URL links to HTML
atags. Unfortunately gerrit will think thatthe ending quote is part of the URL, so it will not remove it. This way the
URL will be invalid.
To solve this problem in this patch we will remove the quotes around the URL link.