[db] Eliminating duplicate key constraint violations #3712
Conversation
| filepath=file_path, | ||
| filename=os.path.basename(file_path), | ||
| content_hash=content_hash).on_conflict_do_nothing( | ||
| index_elements=['id']) |
There was a problem hiding this comment.
index_elements=["content_hash"]?? Shouldn't we list the key clashing constraint fields here?
There was a problem hiding this comment.
Maybe you can test this fix and provoke the error by storing a file to the server (with masstore run) that has been stored already.
There was a problem hiding this comment.
[2022-08-15 09:30:01 UTC] (23505) - ERROR: duplicate key value violates unique constraint "uq_files_filepath"
[2022-08-15 09:30:01 UTC] (23505) - DETAIL: Key (filepath, content_hash)=(/path/to/blabla.h, <hash_value>) already exists.
[2022-08-15 09:30:01 UTC] <???> (23505) - STATEMENT: INSERT INTO files (filepath, filename, content_hash, remote_url, tracking_branch) VALUES ('/path/to/blabla.h', 'blabla.h', '<hash_value>', NULL, NULL) RETURNING files.id
In concurrent storage of two runs containing the same files leads to duplicate key constraint violation. Some DBMSs can gracefully handle this issue by supporting "ON CONFLICT DO NOTHING" clause at INSERT statement.
bruntib
force-pushed
the
duplicate_key_violation
branch
from
ef405cb
to
eebce30
Compare
In concurrent storage of two runs containing the same files leads to
duplicate key constraint violation. Some DBMSs can gracefully handle
this issue by supporting "ON CONFLICT DO NOTHING" clause at INSERT
statement.