Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix three bugs and a couple of style issues #3804

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Fix three bugs and a couple of style issues #3804

merged 1 commit into from
Jan 13, 2023

Conversation

geeksmith
Copy link
Contributor

@geeksmith geeksmith commented Dec 16, 2022 •
edited
Loading

Remove three bugs:

  • $MASTER_EXISTS vs. $PREVIOUS_EXISTS bug fixed with simpler test
  • Using quotes around $ANALYZER_OPTIONS when calling CodeChecker results in an error
  • Fix escaping and indentation of $DIFF_CMD
    • we could use <<- and a real tab to indent END but the web formatting doesn't preserve the tab

Fix style issues:

  • Use a variable instead of a file to store $WAS_OUTPUT
  • Remove superfluous curly braces.

@geeksmith
Fix two bugs and a couple of style issues
1091607 
Remove bugs and superfluous curly braces.
- $MASTER_EXISTS vs. $PREVIOUS_EXISTS bug fixed with simpler test
- Use a variable instead of a file to store $WAS_OUTPUT
- Fix escaping and indentation of $DIFF_CMD
  - we could use <<- and a real tab to indent EOF
@geeksmith geeksmith mentioned this pull request Dec 16, 2022
Closed
@geeksmith geeksmith changed the title Fix two bugs and a couple of style issues Fix three bugs and a couple of style issues Dec 16, 2022
@bruntib bruntib merged commit 56b0ce8 into Ericsson:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruntib bruntib bruntib approved these changes

@dkrupp dkrupp Awaiting requested review from dkrupp dkrupp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@geeksmith @bruntib