[test] Get rid of mockldap #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
force-pushed
the
eliminate_mockldap
branch
from
c0d5272
to
fe02025
Compare
Szelethus
requested changes
Apr 27, 2023
There was a problem hiding this comment.
Please link this issue in the summary:
#3892
Folks that try to build CodeChecker and encounter the error, will google this:
"error in funcparserlib setup command: use_2to3 is invalid."
It would make sense to copy-paste this specific error message into the summary as well, so they would find this PR and know to simply upgrade their version.
Mockldap dependency is not supported for a long time. It can't be installed to the latest Ubuntu versions, due to some of its old version implicit dependencies (funcparserlib). For this reason the usage of mockldap module has been eliminated and a simplified mock class has been introduced instead with hardcoded return values. This error could be reproduced by "make venv_dev" command which emitted this error message: "error in funcparserlib setup command: use_2to3 is invalid." Fixes Ericsson#3892
bruntib
force-pushed
the
eliminate_mockldap
branch
from
fe02025
to
fa1ad5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mockldap dependency is not supported for a long time. It can't be
installed to the latest Ubuntu versions, due to some of its old version
implicit dependencies (funcparserlib). For this reason the usage of
mockldap module has been eliminated and a simplified mock class has been
introduced instead with hardcoded return values.
This error could be reproduced by "make venv_dev" command which emitted
this error message:
"error in funcparserlib setup command: use_2to3 is invalid."
Fixes #3892