Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Change the selected bubble's brightness #3981

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

cservakt
Copy link
Collaborator

@cservakt cservakt commented Aug 15, 2023

To highlight selected bubble on the report page currently we use only a 2px dashed border. It is hard to detect the active chip section when there are many bubbles in one report file. The active bubble is more highlighted when its opacity is 100 and 70% for the others. The font-weight is bold for active and lighter for non actives. The current modifications emphasize the selected bubble more then the dashed border.

@cservakt cservakt added GUI 🎨 web 🌍 Related to the web app labels Aug 15, 2023
@cservakt cservakt added this to the release 6.23.0 milestone Aug 15, 2023
@Szelethus Szelethus changed the title Change the selected bubble's brightness [GUI] Change the selected bubble's brightness Aug 16, 2023
@Szelethus
Copy link
Collaborator

I've added "[GUI]" to your title, if you don't mind. We don't have any very hard and fast rules on when or what tag to use in the title, but we have a .gitmessage file as a general guideline: https://github.com/Ericsson/codechecker/blob/master/.gitmessage

@Szelethus
Copy link
Collaborator

For visual changes like this, please include some pictures!

Here is what the patch does when you select a specific event on the rigth hand side of the report page.

Control flow events

image -> image

Warnings

image -> image

Macros

image -> image

Notes

image -> image

This change is a big improvement from the existing implementation, but I noticed that the selected elements became somewhat darker, instead of brighter -- wouldn't that pop even more? I'm not a designer, so I actually don't know :)

To highlight selected bubble on the report page currently we use only a 2px dashed border. It is hard to detect the active chip section when there are many bubbles in one report file. The active bubble is more highlighted when its opacity is 100 and 70% for the others. The font-weight is bold for active and lighter for non actives. The current modifications emphasize the selected bubble more then the dashed border.
@cservakt
Copy link
Collaborator Author

For visual changes like this, please include some pictures!

Here is what the patch does when you select a specific event on the rigth hand side of the report page.

Control flow events

image -> image

Warnings

image -> image

Macros

image -> image

Notes

image -> image

This change is a big improvement from the existing implementation, but I noticed that the selected elements became somewhat darker, instead of brighter -- wouldn't that pop even more? I'm not a designer, so I actually don't know :)

That's true. Maybe setting opacity is more usefull to highlight the bubbles.
test2

@bruntib bruntib merged commit 6889920 into Ericsson:master Aug 18, 2023
8 checks passed
@cservakt cservakt deleted the bubble-brightness branch September 7, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI 🎨 web 🌍 Related to the web app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants