[report-converter] Support sarif format and Gcc analyzer #4011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szelethus
force-pushed
the
sarif_support
branch
2 times, most recently
from
e7aee25
to
e25c5cc
Compare
|
Turns out we have an entry in the main README for all outputs, need to fix that. |
Szelethus
force-pushed
the
sarif_support
branch
from
8a0b0de
to
61cc0ce
Compare
Szelethus
changed the title
Szelethus
force-pushed
the
sarif_support
branch
from
1833155
to
2930bcf
Compare
bruntib
requested changes
Oct 9, 2023
There was a problem hiding this comment.
Could you, please, try the following scenario:
- Create a .sarif file with gcc static analyzer.
- Use report-converter to convert this .sarif file to .plist
- Use
CodeChecker parse <report folder>to list the reports based on the .plist.
This scenario doesn't work for me when I start from step 2 with double_free.cpp.sarif test file, because CodeChecker parse results this message:
[WARNING 2023-10-09 11:32] - The following source file contents changed or missing since the latest analysis:
- /home/<user>/CodeChecker/codechecker/tools/report-converter/tests/unit/analyzers/gcc_output_test_files/<report_dir>/files/double_free.cpp
Please re-analyze your project to update the reports!
In the original .sarif file the /files/double_free.cpp is not under the <report_dir>.
tools/report-converter/codechecker_report_converter/analyzers/gcc/analyzer_result.py
Outdated
Show resolved
Hide resolved
tools/report-converter/codechecker_report_converter/report/parser/base.py
Outdated
Show resolved
Hide resolved
tools/report-converter/codechecker_report_converter/report/report_file.py
Show resolved
Hide resolved
tools/report-converter/codechecker_report_converter/report/parser/sarif.py
Outdated
Show resolved
Hide resolved
tools/report-converter/codechecker_report_converter/report/parser/sarif.py
Outdated
Show resolved
Hide resolved
tools/report-converter/codechecker_report_converter/report/parser/sarif.py
Outdated
Show resolved
Hide resolved
tools/report-converter/codechecker_report_converter/report/parser/sarif.py
Outdated
Show resolved
Hide resolved
Szelethus
force-pushed
the
sarif_support
branch
2 times, most recently
from
d90eea6
to
1d56191
Compare
Fixes Ericsson#1797. Based on a commit authored by @csordasmarton. Credit goes to him! We've long wanted to support sarif (https://sarifweb.azurewebsites.net/), and finally, this is the first real step towards it! This patch can both parse and export to sarif. My intent is that the code is self explanatory (because I explained things in the code!), there are two things I'd like to highlight: 1. I strugged a LOT with mypy, which lead me to express a things things in a rather cumbersome manner. I left comments around these parts 2. I copied all example tests from https://github.com/microsoft/sarif-tutorials/ to tools/report-converter/tests/unit/parser/sarif/sarif_test_files/. These examples come with an MIT licence, which I also copied over. Co-authored-by: Kristóf Umann <dkszelethus@gmail.com>
Szelethus
force-pushed
the
sarif_support
branch
from
1d56191
to
90a3905
Compare
The test file you tried this out in the tests/ directory was a bit manifactured, as I needed to remove absolute paths in order to satisfy the CI. |
bruntib
approved these changes
Oct 10, 2023
This was referenced Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1797. Based on a commit authored by @csordasmarton. Credit goes to him!
We've long wanted to support sarif
(https://sarifweb.azurewebsites.net/), and finally, this is the first real step towards it!
This patch can both parse and and export to sarif.