New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[analyze] Removing long enabled checker list at info log level #4103
base: master
Are you sure you want to change the base?
Conversation
LOG.info("Enabled checker list can be found in " + | ||
os.path.join(args.output_path, "metadata.json")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOG.info("Enabled checker list can be found in " + | |
os.path.join(args.output_path, "metadata.json")) | |
LOG.info("Enabled checker list can be found in %s", | |
os.path.join(args.output_path, "metadata.json")) |
I totally support this patch -- the default output is still let a little loose on verbosity. With that said, metadata.json isn't very human readable without formatting, so we should consider prettifying it by default. |
@Szelethus The
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Reasoning above.)
LOG.info("Enabled checker list can be found in " + | ||
os.path.join(args.output_path, "metadata.json")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOG.info("Enabled checker list can be found in " + | |
os.path.join(args.output_path, "metadata.json")) |
LOG.debug("Enabled checkers:\n%s", '\n'.join( | ||
k + ': ' + ', '.join(v) for k, v in enabled_checkers.items())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, but maybe could be formatted into one line for each checker.
At every analysis at the defult log level there was a wall of text checker list. It is enough to print this list at the default log level and redirect the user to the metadat.json file at default log level.