Eliminate should skip #4111
Merged
Eliminate should skip #4111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
force-pushed
the
eliminate_should_skip
branch
2 times, most recently
from
79d4af1
to
8ed48e6
Compare
|
Please, merge #4099 first and I can rebase it. |
Many functions and members of `multiprocess` lib are exposed dynamically. For this reason pylint is not able to tell what members this lib has (e.g. `multiprocess.Value()`. So these pylint reports have been suppressed. Another purpose of this commit is to make "superset" relationship for venv_dev: if a CodeChecker developer installs venv_dev, then the content of venv should always be installed. venv_dev just extends them. `multiprocess` was a counterexample for this relationship: it was installed only by `venv` and not `venv_dev`. Such a mistake in the organization of requirements.txt files results missing libraries for developers.
bruntib
force-pushed
the
eliminate_should_skip
branch
from
8ed48e6
to
8f5c564
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SkiplistHandler class had a call() function which forwarded to
should_skip(), so it didn't really had a real purpose. There was
also a "TODO" in the code to eliminate this function.