[report-converter][fix] Don't crash when we can't find the checker name for ubsan #4143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me for ubsan We forgot to inizialize `checker_name` to its default value, which lead to a read-before-assignment crash.
whisperity
reviewed
Jan 3, 2024
Comment on lines
+10
to
+11
| <key>check_name</key> | ||
| <string>UndefinedBehaviorSanitizer</string> |
There was a problem hiding this comment.
How can this be that, if it was supposedly initialised to None?
There was a problem hiding this comment.
The idea is that when checker_name is None, we fall back to a default checker name later down the road, which is the name of the sanitizer.
bruntib
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to inizialize
checker_nameto its default value, which lead to a read-before-assignment crash.