Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional guidance for silicon mac users #4188

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

feyruzb
Copy link
Contributor

@feyruzb feyruzb commented Mar 12, 2024

I modified the instructions for mac users on M1 processors

@feyruzb feyruzb requested a review from dkrupp as a code owner March 12, 2024 04:11
@Szelethus Szelethus added the documentation 📖 Changes to documentation. label Mar 12, 2024
@vodorok vodorok self-requested a review March 12, 2024 13:33
Copy link
Collaborator

@vodorok vodorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my remark!

@@ -19,6 +19,17 @@ You can turn off SIP on El Capitan this way:
* Close the Terminal app.
* Click the  (Apple) menu and select Restart....

Or you can turn off SIP on El Capitan this way(silicon):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rephrase this to:
On Apple silicon, the process of disabling SIP is different:

Copy link
Collaborator

@vodorok vodorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, congrats for your first PR in CodeChecker.

@Szelethus Szelethus merged commit 3fc7c75 into Ericsson:master Mar 14, 2024
8 checks passed
@whisperity whisperity added enhancement 🌟 analyzer 📈 Related to the analyze commands (analysis driver) labels Mar 27, 2024
@whisperity whisperity added this to the release 6.24.0 milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer 📈 Related to the analyze commands (analysis driver) documentation 📖 Changes to documentation. enhancement 🌟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants