fix(migration): Do not emit log output for checker_id normalisation
#4198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whisperity
added
database 🗄️
In case a new product is added to an empty server, what happens in the background is a full "migration" from the "empty" state to the newest schema, which results in the log output that is removed by this patch on the standard output of the server. These lines are not directly needed, but there is no good reason to hide them behind an `if len(...):` check either. In case actual rows are migrated (which never happens when a new product is added to the server), the appropriate output showing the row count of the `UPDATE` statement will be printed to the output normally.
whisperity
force-pushed
the
feat/show-zero-checkers/fix-migration
branch
from
7616c2d
to
386f9ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a new product is added to an empty server, what happens in the background is a full "migration" from the "empty" state to the newest schema, which results in the log output that is removed by this patch on the standard output of the server.
These lines are not directly needed, but there is no good reason to hide them behind an
if len(...):check either. In case actual rows are migrated (which never happens when a new product is added to the server), the appropriate output showing the row count of theUPDATEstatement will be printed to the output normally.