[fix] Links in static HTML files should be relative #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
added
bugfix 🔨
tools 🛠️
whisperity
reviewed
May 7, 2024
| # There are 3 reports in the test file. | ||
| self.assertEqual(len(re.findall('"link": "', content)), 3) | ||
| # The links should be relative so the static HTML folder is | ||
| # prtable. |
There was a problem hiding this comment.
Suggested change
| # prtable. | |
| # portable. |
The links in the static HTML files generated by "CodeChecker parse -e html" should be relative, so the output folder of the above command is portable.
bruntib
force-pushed
the
static_html_relative_link
branch
from
f233107
to
2aa4fdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The links in the static HTML files generated by "CodeChecker parse -e html" should be relative, so the output folder of the above command is portable.