Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Don't emit a missing gcc warning if no checkers are enabled" #4238

Closed
wants to merge 1 commit into from
Closed

Revert "Don't emit a missing gcc warning if no checkers are enabled" #4238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions analyzer/codechecker_analyzer/analyzer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,31 +169,12 @@ def perform_analysis(args, skip_handlers, rs_handler: ReviewStatusHandler,

config_map = analyzer_types.build_config_handlers(args, analyzers)

# Don't enable analyzers that have no checkers enabled. Some analyzers,
# like clang-tidy error out if none of theirs are enabled, which makes
# sense if you use them as a standalone tool, but not if you run a bunch
# of analyzers at once.
no_checker_analyzers = \
[a for a in analyzers if not __has_enabled_checker(config_map[a])]
for analyzer in no_checker_analyzers:
LOG.info("No checkers enabled for %s", analyzer)
analyzers.remove(analyzer)

# Don't emit warnings for analyzers we failed to enable if none of their
# checkers were enabled anyways.
# TODO: Its perfectly reasonable for an analyzer plugin to not be able to
# build their config handler if the analyzer isn't supported in the first
# place. For now, this seems to be okay, but may not be later.
errored_config_map = analyzer_types.build_config_handlers(
args, [x for (x, _) in errored])

no_checker_err_analyzers = \
[a for (a, _) in errored
if not __has_enabled_checker(errored_config_map[a])]

errored = [(an, msg) for an, msg in errored
if an not in no_checker_err_analyzers]

actions = prepare_actions(actions, analyzers)

available_checkers = set()
Expand Down
Loading