Skip to content

Commit

Permalink
Fix a passing XFAIL test
Browse files Browse the repository at this point in the history
Now that we can gracefully handle stack exhaustion, this test was passing in
darwin && asan. Instead, just unsupport it when threading is unavailable.

llvm-svn: 370270
  • Loading branch information
epilk committed Aug 28, 2019
1 parent 027f1da commit 6c7687e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions clang/test/CodeGenCXX/castexpr-basepathsize-threshold.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
// https://bugs.llvm.org/show_bug.cgi?id=38356
// We only check that we do not crash.

// ASAN increases stack usage, so we are hitting stack overflow before reaching
// recursive template instantiation limit.
// XFAIL: darwin && asan
// This test can exceed stack usage in some configurations, so unless we can
// properly handle that don't run it.
// REQUIRES: thread_support

template <typename a, a b(unsigned), int c, unsigned...>
struct d : d<a, b, c - 1> {};
Expand Down

0 comments on commit 6c7687e

Please sign in to comment.