Refactor fact #30
Refactor fact #30
Conversation
|
Are you seeing the unit test timeout with ruby 2.3.1? I'm seeing that with python. You can allow ruby 2.3.1 to fail with this |
|
The downsize would be that Travis is waiting around 10 minutes before failing. This will slow down the testing results quite a lot :( |
|
Think I will add only puppet latests to run with ruby 2.3.1. This would only cost 10 minutes. |
Phil-Friderici
force-pushed
the
refactor_fact
branch
from
999ef35
to
c9c31fc
Compare
|
Breaking news Maybe time is good for a 1.0.0 release ? |
|
|
||
| with_fixtures = { | ||
| 'Debian' => { | ||
| :sudo_output => 'Sudo version 1.8.3p1\nSudoers policy plugin version 1.8.3p1\nSudoers file grammar version 40\nSudoers I/O plugin version 1.8.3p1\n', |
There was a problem hiding this comment.
shouldn't the fixture stay the same as the output has not changed
There was a problem hiding this comment.
Removed it for better alignment. Btw: I have seen likewise output on RedHatish systems as well.
The regex /^Sudo version +(\S+)$/ should be specific enough to not need to test that it ignores the rest of the string.
There was a problem hiding this comment.
True, but we wouldn't know without the whole output. What if we want to tweak our regex? When it comes to fixtures, I think we should take the entire output.
There was a problem hiding this comment.
you'll like my latest change :)
|
+1 for a v1.0.0 release |
Phil-Friderici
force-pushed
the
refactor_fact
branch
from
c9c31fc
to
e447383
Compare
|
The fact does proactivly search for /opt/quest/bin/sudo again. This ensures fully backward compatibility again :) |
|
+1 |
|
moving on to #32 to prepare 1.0.0 release |
No description provided.