-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fully native iOS sample app #49
[WIP] Fully native iOS sample app #49
Conversation
Sets up self view and connects to EventSource server, e.g. demo.openwebrtc.io
Removed EventSource lib source files and put them in Podfile.
Hows this coming along? I noticed with the code you can join a session, but doesn't appear to have the hooks in for video/audio call. |
That's correct. Have been busy the last few weeks but have restarted to work on it again. Check back in a week or two. |
Also added placeholder test methods.
Stefan, Thanks for continuing to push forward on this. I'm attempting to follow along with the NativeDemo WIP from your 'move-to-framework' branch and am running into difficulty resolving the podspec dependencies for 'OpenWebRTC' & 'OpenWebRTC-SDK' from 'openwebrtc-ios-sdk'. I've looked around for this repository to mirror your environment without luck. Can publish this repository or point me in the right direction? |
Hey! The plan is to release CocoaPods in a week or so, and I have been using this app to test things out. There will be 2 different pods available, one for the pre-built OpenWebRTC.framework (no more having to build everything yourself, yey!) and another one containing the SDK. The SDK is a set of helper classes for developing native apps. As the API for the SDK are far from stable I'm a bit reluctant to give you access just yet. But if you are willing to proceed despite many breaking changes on the horizon, perhaps I can reconsider :) |
Stefan, That's great news! I promise not to be a PITA if you are kind enough to grant me early access and will play along on my own fork. I'm not concerned at this point with any breaking changes and merely wish to follow along as we prepare to integrate the native SDK helpers. |
OK. Give me a few minutes. (Btw: the app can now start a session with http://demo.openwebrtc.io if the browser, e.g. Chrome , initiates) |
Now the iOS SDK is public, but don't tell anyone :) https://github.com/EricssonResearch/openwebrtc-ios-sdk You may have to wrestle a bit with the pod's. A few minor manual changes are still required in Xcode after each As always, all feedback is much appreciated. |
@stefanalund: Thank you very much! I'll have a look in bit. |
Currently only video attributes are set.
Latest commit requires EricssonResearch/openwebrtc-ios-sdk#8 |
Stefan, Using the latest commits from 3/26 in _Native Demo_ I can connect and send the selfView, but remoteView is always blank. I see the orientation come back in the following delegate as 0.
Should I be able to render the remoteView at this stage or is this part still WIP? Cheers ~ |
@zombieobject there is currently a problem displaying video in newer builds of OpenWebRTC. Please try with this framework: http://static.verkstad.net/OpenWebRTC.framework_old.zip Using this (old) framework I get video in both directions with the NativeDemo app. |
I think it's time to review this now. @Rugvip @superdump |
#import <Foundation/Foundation.h> | ||
|
||
#define kVideoBitrate 768000 | ||
#define kSupportedVideoModes @[@"QCIF",@"QVGA",@"CIF",@"360p",@"VGA",@"720p"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1080p? 😄
OpenWebRTCNativeHandler now lives in openwebrtc-ios-sdk
@superdump updated commit addresses all your comments. Thanks. |
Looks good to me. If it works, I don't see any glaring issues with the code but it's difficult to look too closely at so much new code. 😄 |
[WIP] Fully native iOS sample app
@stefanalund hrm... I linked your aforementioned archive framework and yielded the same empty frame. I was sidetracked with a point release during my afternoon and will try again on Monday. I did note the GStreamer bug identified in the OpenWebRTC IRC channel and wonder if this is in fact the culprit. Thanks again, and keep up the great work! Cheers~ |
NativeDemo application that connects to demo.openwebrtc.io and uses OpenWebRTC's C API.
Work in progress, do not land