Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor EAGL initialization flow causing GL failure on iOS. #283

Closed
ijsf opened this issue Mar 28, 2015 · 8 comments
Closed

Poor EAGL initialization flow causing GL failure on iOS. #283

ijsf opened this issue Mar 28, 2015 · 8 comments

Comments

@ijsf
Copy link
Contributor

ijsf commented Mar 28, 2015

This is actually a flow bug in gstreamer (bad plugins) causing issues on iOS 8.x.

A FIXME in gst_gl_window_set_window_handle is causing issues. Here, the set_window_handle function is being called asynchronously and is only actually called after the relevant thread is started. This happens after the GL context has been created, while GL context creation function gst_gl_context_eagl_create_context expects a valid window handle.

A workaround has been committed in my fork and seems to solve this specific case: ijsf/OpenWebRTC-gst-plugins-bad@16bab0b

@superdump
Copy link
Contributor

Can you submit the patch to upstream GStreamer bugzilla? Probably even this ticket: https://bugzilla.gnome.org/show_bug.cgi?id=745090

@superdump
Copy link
Contributor

Oh, it's basically reverting the change as @ikonst posted there. Never mind then. But thanks for more details on the problem. :)

@ijsf
Copy link
Contributor Author

ijsf commented Mar 28, 2015

Yeah, it's more like a stopgap solution for iOS. I'm not sure why the FIXME was put there.

@ijsf
Copy link
Contributor Author

ijsf commented Mar 29, 2015

Possibly a duplicate of #280. Seems to be caused by the same issue, or rather, a fix of the bug below would likely fix this issue as well.

Also see: https://bugzilla.gnome.org/show_bug.cgi?id=745090

@alessandrod
Copy link
Contributor

I'm working on this and have a working patch. I will polish it and push upstream.

@alessandrod
Copy link
Contributor

commit 6981a8d15b17094cde8a2cec0a2c821c6eaa9547
Author: Alessandro Decina alessandro.d@gmail.com
Date: Thu Apr 2 18:05:55 2015 +1100

libgstgl: fix rendering on iOS

Stop assuming that the handle has been set by the time ->create_context is
called. After bc7a7259f357b0065dd94e0668b5a895d83fa53a set_window_handle always
happens after ->create_context in fact.

See also https://bugzilla.gnome.org/show_bug.cgi?id=745090

@superdump
Copy link
Contributor

@alessandrod can I close this then?

@superdump
Copy link
Contributor

Closing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants