-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poor EAGL initialization flow causing GL failure on iOS. #283
Comments
Can you submit the patch to upstream GStreamer bugzilla? Probably even this ticket: https://bugzilla.gnome.org/show_bug.cgi?id=745090 |
Oh, it's basically reverting the change as @ikonst posted there. Never mind then. But thanks for more details on the problem. :) |
Yeah, it's more like a stopgap solution for iOS. I'm not sure why the FIXME was put there. |
Possibly a duplicate of #280. Seems to be caused by the same issue, or rather, a fix of the bug below would likely fix this issue as well. |
I'm working on this and have a working patch. I will polish it and push upstream. |
commit 6981a8d15b17094cde8a2cec0a2c821c6eaa9547
|
@alessandrod can I close this then? |
Closing. Thanks! |
This is actually a flow bug in gstreamer (bad plugins) causing issues on iOS 8.x.
A FIXME in
gst_gl_window_set_window_handle
is causing issues. Here, theset_window_handle
function is being called asynchronously and is only actually called after the relevant thread is started. This happens after the GL context has been created, while GL context creation functiongst_gl_context_eagl_create_context
expects a valid window handle.A workaround has been committed in my fork and seems to solve this specific case: ijsf/OpenWebRTC-gst-plugins-bad@16bab0b
The text was updated successfully, but these errors were encountered: