Implement PeerHandler.stop()

[stefanalund]

The following is logged e.g. on page reloads: PeerHandler.stop() called (not implemented)

[sdroege]

The ground work for this should be done with https://github.com/sdroege/openwebrtc/tree/pipeline-refactoring

Not sure if something else is still missing other than implementing PeerHandler.stop() in the JS layer.

[superdump]

There we need to set_*source NULL on the media sessions and renderers and then unref the renderers and transport agent. I think that should be all.

[sdroege]

The problem is that JS (and other GC'd languages) don't give you a way to "unref" something. Which might be an argument for adding some kind of "stop" function to the renderers and transport agents to let them release all their resources immediately. Could be called "dispose" like in Java, C# and others, I don't know what JS people usually do there. And after calling that, every other action on the object is invalid.

[stefhak]

Relevant JS methods:
MediaStreamTrack.stop();
RTCPeerConnection.close();
RTCDataChannel.close(); //once someone implements support for data channels

Note that the objects are still around (and the app is able to read out statistics for example) after stopping/closing, but they can't be used for anything meaningful.

[sdroege]

This is being worked on here: https://github.com/pererikb/openwebrtc/commits/js_shutdown

[sdroege]

@pererikb , is that ready to be merged?

[pererikb]

Yes