code climate fix

ErikLG360 · Dec 4, 2023 · e95656f · e95656f
1 parent 64b210d
commit e95656f
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/app/controllers/grading_histories_controller.rb b/app/controllers/grading_histories_controller.rb
@@ -7,7 +7,7 @@ def action_allowed?
     # admins and superadmins are always allowed
     return true if current_user_has_admin_privileges?
     # populate assignment fields
-    assignment_for_history(params[:grade_type])
+    populate_assignment_fields
     # if not admin/superadmin, check permissions
     if @assignment.instructor_id == current_user.id
       true
@@ -19,6 +19,11 @@ def action_allowed?
     end
   end
 
+  private
+  def populate_assignment_fields
+    assignment_for_history(params[:grade_type])
+  end
+
   # populate the assignment fields according to type
   def assignment_for_history(type)
     # for a submission, the receiver is an AssignmentTeam