Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per app volume control #235

Merged
merged 5 commits into from
Apr 11, 2023
Merged

Conversation

JannisPetschenka
Copy link
Contributor

Haven't tested everything yet, but apart from that should be ready :)

@ErikReider
Copy link
Owner

I'll try to get to this tonight. If not, ping me :)

Copy link
Owner

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Finally had some free time after "finishing" blur work in SwayFX :)

src/configSchema.json Outdated Show resolved Hide resolved
src/controlCenter/widgets/volume/volume.vala Outdated Show resolved Hide resolved
src/controlCenter/widgets/volume/volume.vala Outdated Show resolved Hide resolved
man/swaync.5.scd Show resolved Hide resolved
src/configSchema.json Show resolved Hide resolved
@JannisPetschenka
Copy link
Contributor Author

Sorry for the delay. Finally had some free time after "finishing" blur work in SwayFX :)

No worries 😄 I'm aware of the issue with deleting elements. The reason is that I close the client when the cc is closed. And since the remove_active_sink signal is only send while the client is active, the remove function is never called....

To solve this I could either never close the client or always update the active sinks when opening the cc... But solutions seem sub-optimal to me. I'll see if I can find a better way :)

@ErikReider
Copy link
Owner

or always update the active sinks when opening the cc... But solutions seem sub-optimal to me.

If there's no other way, this would be the more optimal solution :)

@JannisPetschenka
Copy link
Contributor Author

Finally found the time to look into it again :) Should work now 😄
Currently if there are no active sink_inputs you can still reveal the levels_listbox and it will just show an empty list... Might change that but apart from that it should be ready :)

@JannisPetschenka
Copy link
Contributor Author

Fixed the issues and added a label to be displayed when the list of active sink inputs is empty :) Should be ready now 😄

@JannisPetschenka JannisPetschenka marked this pull request as ready for review April 7, 2023 13:41
@ErikReider
Copy link
Owner

Probably just a line ending issue

Copy link
Owner

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again for all of the help :)

@ErikReider ErikReider merged commit 91f19df into ErikReider:main Apr 11, 2023
5 checks passed
@JannisPetschenka JannisPetschenka deleted the per-app-volume branch November 12, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants