Nicer spec file #270
Merged
Nicer spec file #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build script wont complete but it's not a issue with this PR. I'll have to solve this soon. Thanks for the improvement :) If it goes a few days without a review, please ping me :) |
|
Sure, no problem |
ErikReider
requested changes
May 30, 2023
|
You're using rpmlint right? Any specific config that you'd recommend? The GitHub action is only using the stock config |
|
@ErikReider yes, I'm using rpmlint executed on built packages, vanilla configuration from Fedora (included with rpmlint rpm). |
ErikReider
approved these changes
May 30, 2023
|
My pleasure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec file with recommended build dependency list and sub packages for completion functions.