Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meson_option to build without PulseAudio Widget #297

Merged
merged 3 commits into from
Jul 8, 2023

Conversation

ErikReider
Copy link
Owner

@ErikReider ErikReider commented Jul 8, 2023

Fixes: #271

meson build -Dpulse-audio=false configures it to build without PulseAudio

@ErikReider ErikReider added the enhancement New feature or request label Jul 8, 2023
@ErikReider ErikReider added this to the v1.0.0 milestone Jul 8, 2023
@ErikReider ErikReider self-assigned this Jul 8, 2023
@ErikReider
Copy link
Owner Author

@freijon If this works as expected on your end, I'll merge it :)

@freijon
Copy link
Contributor

freijon commented Jul 8, 2023

Hello @ErikReider

Thanks! I created a test package and the new option works like a charm.
The only thing I notice is that the man-pages still have the the pulse-stuff in them even if built without pulse. I patched that out as well in our package. I'd consider this a bonus goal though ;)

@ErikReider
Copy link
Owner Author

ErikReider commented Jul 8, 2023

I'll check if there's a way of patching out sections through meson

@ErikReider
Copy link
Owner Author

The only thing I notice is that the man-pages still have the the pulse-stuff in them even if built without pulse

Added a "hacky" way of doing this. It works like a charm though :)

@ErikReider ErikReider merged commit 90cde83 into main Jul 8, 2023
6 checks passed
@ErikReider ErikReider deleted the build-without-pulseaudio branch July 8, 2023 15:24
@ErikReider ErikReider removed this from the v1.0.0 milestone Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Make pulseaudio optional
2 participants