#issue15 - Observable notifications #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is great! Thanks a lot for the help. I only have one small issue, and that is that the PR seems to have changed a lot of lines without doing any actual changes (only some whitespace removal and such). In this case, it was not too hard to verify that nothing realled changed, but normally you'd want to prevent doing such cosmetic changes in a PR, as it makes it harder to actually see what changed :) I'll merge this (through a rebase squash as you have two commits) and update the version number. Thanks so much for the help! |
|
@guilhermewaess The PR has been merged and I just published a new version (0.3.1) to NPM and Bower. Once again, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I'm not sure about tests with chai, please can you help and make your considerations?
Nice lib :)