-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Typing Errors #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thanks for reporting the issue and even submitting a PR to fix it! I have one request: instead of commenting the unnecessary lines, could you remove them?
I removed the unnecessary lines, hope you could merge now peacefully. Thanks! |
dist/knockout.d.ts
Outdated
@@ -35,7 +29,7 @@ interface KnockoutObservableArrayFunctions<T> { | |||
sort(compareFunction: (left: T, right: T) => number): void; | |||
|
|||
// Ko specific | |||
[key: string]: KnockoutBindingHandler; | |||
// [key: string]: KnockoutBindingHandler; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you perhaps also remove this comment?
Thanks for your attention, check now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thanks. 🎉
Referring to #19
This is the proposed solution.