-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New features for pregnant plugin #22
Conversation
FYI, VS Code applied lots of automatic whitespace changes to JSON files, to avoid looking through them on GitHub you can use the https://github.com/ErinaSugino/Starbound-SBR-Mod/pull/22/files?w=1 |
On another note: The mechanic consists of two independent parts - the added fertility bonus on successful sub-sequent climaxes, as well as the cumflation logic of displaying the pregnant belly sprite after enough overall climaxes. So far, however, both these mechanics are triggered simultaneously resulting in a logical error. That the fertility bonus is triggered after all pregnancy validation checks ran makes sense. That, however, the general "you're getting full" part of the logic too is bound by (except for the actual fertility roll) all requirements for a pregnancy being fulfilled is not. Here is a good example: SBR only sends a pregnancy attempt request from the climax plugin to the pregnancy plugin when the climaxing actor has the necessary conditions to impregnate anyone in the first place. However, different conditions are applied to generally climaxing. This results in, e.g., an infertile or sterilized actor still logically climaxing, still logically "filling the other actor up", but never sending a request to the pregnancy plugin, hence never increasing the statistic. You should probably outsource this part of the logic elsewhere, or at least make sure the actual tracking of current stored shots is triggered independently from impregnation requests, by making the climax plugin send another different event message you hook into. EDIT: |
Alright, this should cover everything you mentioned |
Proper way of initializing in internally managing new variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough. The fertility bonus vs. inflation split still needs more solid separation, though this isn't critical for now. I'll look into this later.
Climax counter could be moved to climax plugin, since pregnant plugin depends on it anyway, then new bonus would remain in pregnant and inflation made its own new plugin? |
No need to make it its own plugin. But like I already mentioned in my previous notes, the climax plugin will have be involved in some way. |
New features:
Also changed default fertility to 30% to facilitate the use of the new bonus.