Added a test for 404s

ErisDS · Jan 25, 2022 · eb73f62 · eb73f62
1 parent 2b5f7ef
commit eb73f62
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 3 deletions.
diff --git a/packages/express-test/test/app.test.js b/packages/express-test/test/app.test.js
@@ -35,6 +35,15 @@ Object.keys(agents).forEach((agentName) => {
             text.should.eql('{"posts":[{"id":42,"title":"Hello World!"}]}');
         });
 
+        it('wrong param', async function () {
+            const {statusCode, headers, body, text} = await agent.get('/posts/404/');
+
+            statusCode.should.eql(404);
+            headers.should.be.an.Object().with.properties('x-powered-by', 'content-type', 'content-length', 'etag');
+            body.should.eql({});
+            text.should.eql('Not Found');
+        });
+
         it('PUT JSON', async function () {
             const {statusCode, headers, body, text} = await agent.put('/posts/42/', {
                 body: {posts: [{title: 'So long and thanks for all the fish.'}]}
@@ -71,6 +80,15 @@ describe('Testing with supertest', function () {
         text.should.eql('{"posts":[{"id":42,"title":"Hello World!"}]}');
     });
 
+    it('wrong param', async function () {
+        const {statusCode, headers, body, text} = await agent.get('/posts/404/');
+
+        statusCode.should.eql(404);
+        headers.should.be.an.Object().with.properties('x-powered-by', 'content-type', 'content-length', 'etag');
+        body.should.eql({});
+        text.should.eql('Not Found');
+    });
+
     it('PUT JSON', async function () {
         const {statusCode, headers, body, text} = await agent
             .put('/posts/42/')

diff --git a/packages/express-test/test/fixtures/app.js b/packages/express-test/test/fixtures/app.js
@@ -7,21 +7,28 @@ const path = require('path');
 app.use(express.json());
 
 app.get('/', (req, res) => {
-    res.send('Hello World!');
+    return res.send('Hello World!');
 });
 
 app.get('/posts/:id/', async (req, res) => {
+    if (req.params.id !== '42') {
+        return res.sendStatus(404);
+    }
+
     const response = await fs.readFile(path.join(__dirname, 'post.json'), {encoding: 'utf8'});
     const json = JSON.parse(response);
-    res.json(json);
+    return res.json(json);
 });
 
 app.put('/posts/:id', async (req, res) => {
+    if (req.params.id !== '42') {
+        return res.sendStatus(404);
+    }
     const response = await fs.readFile(path.join(__dirname, 'post.json'), {encoding: 'utf8'});
     const json = JSON.parse(response);
     json.posts[0] = Object.assign(json.posts[0], req.body.posts[0]);
 
-    res.json(json);
+    return res.json(json);
 });
 
 module.exports = app;