Custom oef (reduce food glow and other zoom maintain) #311

tjorim · 2016-06-23T08:57:48Z

Description

Create custom redraw() for foodglow, this modifies the standard one.

Remove the foodglow as suggested by @pllsner in #310 , the issue is also stated in #236 .
Since this modifies the redraw()-function, the zoom is altered as well
instead of calling an extra function on each redraw.

TESTING STAGE

Current bot (develop and master is the same):

games 99
median 1944
average 4883

After these commits:

games 125
median 2810
average 5480

I have let a few bots run overnight, all scores where put in an excel-file where I did some quick statistics. I ran 4 bots: master, develop and 2x the custom_oef branch.

Map1.xlsx <-- Here are the results!!!

Both master and develop branches have the same bot code, you can see that the results differ a lot. This is just to demonstrate that 2 running bots can have totally different scores.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have read CONTRIBUTING.md
I fully understand the Github Flow and I'm merging into the develop branch , which is the default branch, and not the master branch
My code adheres to the code style of this project but most importantly of all to the things mentioned, which I have read, in CONTRIBUTING.md
If my change requires a change to the documentation, I have updated the documentation in /docs accordingly.
I have included the results of the test required.

@pllsner

Remove the foodglow as suggested by @pllsner in #236 Since this modifies the redraw()-function, the zoom is altered as well instead of calling an extra function on each redraw.

Fix typos in custom redraw.

houndci-bot · 2016-06-23T08:57:56Z

bot.user.js

+        'gsc!=f&&(gsc<f?(gsc+=2E-4,gsc>=f&&(gsc=f)):(gsc-=2E-4,gsc<=f&&(gsc=f)))', '');
+    new_redraw_string = new_redraw_string.replace(/b.globalCompositeOperation="lighter"/gi,
+        'b.globalCompositeOperation="hard-light"');
+    var new_redraw = new Function(new_redraw_string.substring(


The Function constructor is eval.

tjorim · 2016-06-23T08:58:27Z

👍 I would say 😄

ChadSki · 2016-06-23T18:15:45Z

Alright! Excited to see this change get in. I will test tonight!

alexzeit · 2016-06-24T04:50:45Z

The current zoom is not stored for the next game after respawn.
Suggestion: set the same one collor for all food (b=per_color_imgs[number])

I have tried to set one collor for all foods in the same way but without success, could you have a look on this:

var original_newfood = window.newFood;
var original_newfood_string = original_newfood.toString();
var newfood_string = original_newfood_string.replace(/per_color_imgs\[e.cv/gi, 'per_color_imgs[10');

window.newFood = new Function(newfood_string.substring(
newfood_string.indexOf('{') + 1, newfood_string.lastIndexOf('}')));

ermiyaeskandary · 2016-06-24T14:23:29Z

100% approved! Looks great and after (not alot of) testing, it doesn't seem to have an influence on performance - after all, it should be improving it anyway
Great job @tjorim !
Approved (edit: forgot)

ChadSki · 2016-06-24T19:49:55Z

👍

tjorim · 2016-06-25T08:25:45Z

@alexzeit That's already in the script somewhere.

Seple · 2016-06-25T10:30:09Z

Please add a standard "master" code

ChadSki · 2016-06-28T05:20:39Z

We need more approvals! @OneEyed @chancity @MattDuffin @Drflash55 @ermiyaeskandary @Evanito @FliiFe @K00sKlust @j-c-m @clemens-tolboom

FliiFe · 2016-06-28T11:55:07Z

Approved 👍

Evanito · 2016-06-28T16:55:13Z

👍
Looks good to me!

ermiyaeskandary · 2016-06-28T21:33:24Z

Approved (forgot otherwise I had approved it long time ago ;))

ChadSki · 2016-06-28T22:10:46Z

Nice work @tjorim, thanks for landing this feature! 🎉

HamishBlank · 2016-06-28T22:19:41Z

Performance has dropped severely after this merge. Windows 10 Firefox 47 with greasemonkey

FliiFe · 2016-06-28T22:27:18Z

@HamishBlank Can you try with the commit right before the merge to confirm
this is the issue ?

Le mer. 29 juin 2016 00:19, HamishBlank notifications@github.com a écrit :

Performance has dropped severely after this merge. Windows 10 Firefox 47
with greasemonkey

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#311 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AIVeIfTbedtkAegEa-mxPcgiDdLyEeZ-ks5qQZ3-gaJpZM4I8l1k
.

HamishBlank · 2016-06-28T22:31:11Z

commit 420e562 is the commit right before, and screen goes completely blank edit: except for the background

commit 0e3a1b4 the one before 420e562 performance is back to normal without issues

HamishBlank · 2016-06-28T23:42:52Z

working fine in Google chrome 51.0.2704.103 tampermonkey windows 10, only a slight/very minimal difference between 0e3a1b4 and latest

ChadSki · 2016-06-29T04:10:59Z

Dang, I tested in Chrome and didn't catch this. :P

Opening issue #315 to track this.

tjorim added 2 commits June 20, 2016 17:30

Create custom redraw() for foodglow

420e562

Remove the foodglow as suggested by @pllsner in #236 Since this modifies the redraw()-function, the zoom is altered as well instead of calling an extra function on each redraw.

Fix typos in custom redraw

3e231de

Fix typos in custom redraw.

houndci-bot reviewed Jun 23, 2016
View reviewed changes

ChadSki added the type:feature label Jun 23, 2016

ChadSki added this to the Graphics and UI milestone Jun 23, 2016

Evanito modified the milestones: Choose Server by IP, Graphics and UI Jun 28, 2016

ermiyaeskandary merged commit 24eec6b into develop Jun 28, 2016

This was referenced Jun 29, 2016

Suggestion for Reduce food glow ? #236 #310

Closed

Reduce food glow ? #236

Closed

Bad Performance with Firefox+Greasemonkey since 24eec6b #315

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom oef (reduce food glow and other zoom maintain) #311

Custom oef (reduce food glow and other zoom maintain) #311

tjorim commented Jun 23, 2016 •

edited

Loading

houndci-bot Jun 23, 2016

tjorim commented Jun 23, 2016 •

edited by Drflash55

Loading

ChadSki commented Jun 23, 2016

alexzeit commented Jun 24, 2016 •

edited

Loading

ermiyaeskandary commented Jun 24, 2016 •

edited by Drflash55

Loading

ChadSki commented Jun 24, 2016 •

edited by Drflash55

Loading

tjorim commented Jun 25, 2016

Seple commented Jun 25, 2016 •

edited

Loading

ChadSki commented Jun 28, 2016

FliiFe commented Jun 28, 2016 •

edited by Drflash55

Loading

Evanito commented Jun 28, 2016 •

edited by Drflash55

Loading

ermiyaeskandary commented Jun 28, 2016

ChadSki commented Jun 28, 2016

HamishBlank commented Jun 28, 2016

FliiFe commented Jun 28, 2016

HamishBlank commented Jun 28, 2016 •

edited

Loading

HamishBlank commented Jun 28, 2016

ChadSki commented Jun 29, 2016

Custom oef (reduce food glow and other zoom maintain) #311

Custom oef (reduce food glow and other zoom maintain) #311

Conversation

tjorim commented Jun 23, 2016 • edited Loading

Description

TESTING STAGE

Current bot (develop and master is the same):

After these commits:

Types of changes

Checklist:

houndci-bot Jun 23, 2016

Choose a reason for hiding this comment

tjorim commented Jun 23, 2016 • edited by Drflash55 Loading

ChadSki commented Jun 23, 2016

alexzeit commented Jun 24, 2016 • edited Loading

ermiyaeskandary commented Jun 24, 2016 • edited by Drflash55 Loading

ChadSki commented Jun 24, 2016 • edited by Drflash55 Loading

tjorim commented Jun 25, 2016

Seple commented Jun 25, 2016 • edited Loading

ChadSki commented Jun 28, 2016

FliiFe commented Jun 28, 2016 • edited by Drflash55 Loading

Evanito commented Jun 28, 2016 • edited by Drflash55 Loading

ermiyaeskandary commented Jun 28, 2016

ChadSki commented Jun 28, 2016

HamishBlank commented Jun 28, 2016

FliiFe commented Jun 28, 2016

HamishBlank commented Jun 28, 2016 • edited Loading

HamishBlank commented Jun 28, 2016

ChadSki commented Jun 29, 2016

tjorim commented Jun 23, 2016 •

edited

Loading

tjorim commented Jun 23, 2016 •

edited by Drflash55

Loading

alexzeit commented Jun 24, 2016 •

edited

Loading

ermiyaeskandary commented Jun 24, 2016 •

edited by Drflash55

Loading

ChadSki commented Jun 24, 2016 •

edited by Drflash55

Loading

Seple commented Jun 25, 2016 •

edited

Loading

FliiFe commented Jun 28, 2016 •

edited by Drflash55

Loading

Evanito commented Jun 28, 2016 •

edited by Drflash55

Loading

HamishBlank commented Jun 28, 2016 •

edited

Loading