-
Notifications
You must be signed in to change notification settings - Fork 124
Custom oef (reduce food glow and other zoom maintain) #311
Conversation
Fix typos in custom redraw.
'gsc!=f&&(gsc<f?(gsc+=2E-4,gsc>=f&&(gsc=f)):(gsc-=2E-4,gsc<=f&&(gsc=f)))', ''); | ||
new_redraw_string = new_redraw_string.replace(/b.globalCompositeOperation="lighter"/gi, | ||
'b.globalCompositeOperation="hard-light"'); | ||
var new_redraw = new Function(new_redraw_string.substring( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Function constructor is eval.
Alright! Excited to see this change get in. I will test tonight! |
I have tried to set one collor for all foods in the same way but without success, could you have a look on this:
|
100% approved! Looks great and after (not alot of) testing, it doesn't seem to have an influence on performance - after all, it should be improving it anyway |
@alexzeit That's already in the script somewhere. |
Please add a standard "master" code |
We need more approvals! @OneEyed @chancity @MattDuffin @Drflash55 @ermiyaeskandary @Evanito @FliiFe @K00sKlust @j-c-m @clemens-tolboom |
Approved (forgot otherwise I had approved it long time ago ;)) |
Nice work @tjorim, thanks for landing this feature! 🎉 |
Performance has dropped severely after this merge. Windows 10 Firefox 47 with greasemonkey |
@HamishBlank Can you try with the commit right before the merge to confirm Le mer. 29 juin 2016 00:19, HamishBlank notifications@github.com a écrit :
|
working fine in Google chrome 51.0.2704.103 tampermonkey windows 10, only a slight/very minimal difference between 0e3a1b4 and latest |
Dang, I tested in Chrome and didn't catch this. :P Opening issue #315 to track this. |
Description
Create custom redraw() for foodglow, this modifies the standard one.
Remove the foodglow as suggested by @pllsner in #310 , the issue is also stated in #236 .
Since this modifies the redraw()-function, the zoom is altered as well
instead of calling an extra function on each redraw.
TESTING STAGE
Current bot (develop and master is the same):
After these commits:
I have let a few bots run overnight, all scores where put in an excel-file where I did some quick statistics. I ran 4 bots: master, develop and 2x the custom_oef branch.
Map1.xlsx <-- Here are the results!!!
Both master and develop branches have the same bot code, you can see that the results differ a lot. This is just to demonstrate that 2 running bots can have totally different scores.
Types of changes
Checklist: