New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test failure if pytest's flaky plugin is installed #104
Conversation
Disable pytest's flaky plugin in test_simple_pytest_import_error_cli in order to fix a test failure due to it mangling pytest's return code on import error.
What environment was this error caused in? None of the dashboards seem to have caught it. I'm happy to merge this, but I'd also like to reproduce the error so I can understand it and prevent similar errors in the future. (I'm also wondering why the CircleCI dashboards aren't running, but maybe they will if I merge this into the development branch for 0.15.9, probably a permission issue.). |
It happens if |
I was able to reproduce this. It looks like with flaky installed the error code returned is a 3 instead of 1:
Perhaps we could just change the assert to check that |
I'm happy with any solution that makes the tests pass. |
If you make modify the PR to make that change I'll merge it and push out a new patch. |
Thanks for this bug report! I pushed up the appropriate commits to this branch. Merging. Do you need a new version of xdoctest with this fix released on pypi anytime soon? If so I can push one up and bump the patch version, if not I might wait a bit before making the new release. |
Disable pytest's flaky plugin in test_simple_pytest_import_error_cli
in order to fix a test failure due to it mangling pytest's return code
on import error.