fix: Max-Depth now throws a graphql error rather than syntax error #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: syntax error to new graphqlerror
🦋 Changeset detectedLatest commit: 818ac99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chore(changelog): updated the changelog in max-depth to 2.3.0
nullswan
requested changes
Dec 19, 2023
Comment on lines
3
to
8
| ## 2.3.0 | ||
|
|
||
| ### Minor Changes | ||
|
|
||
| - 32db0f2: fix: Max-Depth now throws a graphql error rather than syntax error issue [#572](https://github.com/Escape-Technologies/graphql-armor/pull/572) | ||
|
|
There was a problem hiding this comment.
This is auto generated by running yarn changeset
There was a problem hiding this comment.
I have updated this & removed the manual update of the package.json version too, Very cool. Might have to add something similar to our projects.
chore(changelog): reset manual changelog to use yarn changeset
nullswan
approved these changes
Dec 20, 2023
|
🎉🚀 |
Merged
|
Hey @samstitt, This has been released in graphql-armor@2.4.0, thanks for you contribution 🎉🚀. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Max-Depth now throws a graphql error rather than syntax error, This is related to the issue raised #571. It also aligns to to other packages such as max-aliases