[14.0][MIG] epa_account_custom: Migration to 14.0 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 14.0 #35 +/- ##
==========================================
+ Coverage 79.41% 84.61% +5.20%
==========================================
Files 5 12 +7
Lines 68 91 +23
Branches 10 13 +3
==========================================
+ Hits 54 77 +23
Misses 8 8
Partials 6 6 ☔ View full report in Codecov by Sentry. |
kaynnan
requested changes
Nov 24, 2023
There was a problem hiding this comment.
Bom teste funcional está okay e questões de código também, notei que no commit do IMP ocorreu a adição do arquivo manifest e readme, ele deveria conter somente a parte do setup/
O restante que está envolvido com ele seria no commit de MIG.
Para ajustar essa questão dos commit, roda o comando git reset HEAD~2, ele vai te trazer os dados dos 2 ultimos commit seu (IMP e MIG), faz o git add do setup/ para o Commit de IMP e o restante para MIG
WesleyOliveira98
force-pushed
the
14.0-mig-epa_account_custom
branch
from
b13f59b
to
e340f52
Compare
kaynnan
approved these changes
Nov 27, 2023
marcelsavegnago
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.