Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importing and exporting other assets than images #32

Merged
merged 2 commits into from
May 18, 2023
Merged

Conversation

dicani0
Copy link
Contributor

@dicani0 dicani0 commented May 17, 2023

No description provided.

@dicani0
Copy link
Contributor Author

dicani0 commented May 17, 2023

Depends on escolalms/topic-types EscolaLMS/topic-types#70

Copy link
Collaborator

@qunabu qunabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #32 (f32a4df) into main (ec63dd4) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #32      +/-   ##
============================================
+ Coverage     92.88%   93.00%   +0.11%     
- Complexity      157      158       +1     
============================================
  Files            21       21              
  Lines           492      500       +8     
============================================
+ Hits            457      465       +8     
  Misses           35       35              
Impacted Files Coverage Δ
src/Services/ExportImportService.php 96.27% <100.00%> (+0.14%) ⬆️

@qunabu qunabu merged commit a524c3a into main May 18, 2023
8 of 9 checks passed
@qunabu qunabu deleted the feature/WC-838 branch May 18, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants