Merge pull request #8 from EscolaLMS/feature/nullable-desc

Make description field nullable

database/migrations/2024_04_09_062138_change_description_column_in_dictionary_words_table.php

@@ -0,0 +1,22 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+return new class extends Migration
+{
+    public function up(): void
+    {
+        Schema::table('dictionary_words', function (Blueprint $table) {
+            $table->text('description')->nullable()->change();
+        });
+    }
+
+    public function down(): void
+    {
+        Schema::table('dictionary_words', function (Blueprint $table) {
+            $table->text('description')->nullable(false)->change();
+        });
+    }
+};

src/Imports/DictionaryWordsImport.php

@@ -36,7 +36,7 @@ public function model(array $row): DictionaryWord
     public function rules(): array
     {
         return [
-            '*.0' => ['required', 'string', 'max:255'],
+            '*.0' => ['required', 'max:255'],
             '*.1' => ['nullable', 'string'],
             '*.2' => ['nullable', 'array'],
             '*.2.*' => ['string', 'exists:categories,name'],

tests/Api/DictionaryWord/AdminCreateDictionaryWordApiTest.php

@@ -75,4 +75,21 @@ public function testAdminCreateDictionaryWord(): void
             ])
             ->assertJsonCount(3, 'data.categories');
     }
+
+    public function testAdminCreateDictionaryWordWithNullDescription(): void
+    {
+        $dictionaryWordData = DictionaryWord::factory()->make();
+        $this->actingAs($this->makeAdmin(), 'api')
+            ->postJson('api/admin/dictionary-words', [
+                ...$dictionaryWordData->toArray(),
+               'description' => null,
+            ])
+            ->assertCreated()
+            ->assertJsonFragment([
+                'word' => $dictionaryWordData->word,
+                'dictionary_id' => $dictionaryWordData->dictionary_id,
+                'description' => null,
+                'data' => $dictionaryWordData->data,
+            ]);
+    }
 }

tests/Api/DictionaryWord/AdminImportDictionaryWordApiTest.php

@@ -51,7 +51,6 @@ public function testAdminImportDictionaryWordsValidation(): void
                     null,
                     true
                 ),
-
             ])
             ->assertUnprocessable();
     }