Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add models to administrable config #2

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Add models to administrable config #2

merged 3 commits into from
Nov 2, 2023

Conversation

dyfero
Copy link
Collaborator

@dyfero dyfero commented Oct 31, 2023

No description provided.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9667776) 98.06% compared to head (22be891) 97.19%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main       #2      +/-   ##
============================================
- Coverage     98.06%   97.19%   -0.88%     
- Complexity       50       59       +9     
============================================
  Files            14       15       +1     
  Lines           155      178      +23     
============================================
+ Hits            152      173      +21     
- Misses            3        5       +2     
Files Coverage Δ
src/EscolaLmsRecommenderServiceProvider.php 100.00% <100.00%> (ø)
src/Providers/SettingsServiceProvider.php 85.71% <100.00%> (+5.71%) ⬆️
src/Services/RecommenderService.php 100.00% <100.00%> (ø)
src/Listeners/UpdateRecommenderModels.php 90.00% <90.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qunabu qunabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@qunabu qunabu merged commit e68c475 into main Nov 2, 2023
7 of 9 checks passed
@qunabu qunabu deleted the feature/update-models branch November 2, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants