report bro config default (#29)

* report bro config default * report bro config default * report bro config default * Update src/EscolaLmsTemplatesPdfServiceProvider.php Co-authored-by: Maciej Rymarz <59456825+mako321@users.noreply.github.com> --------- Co-authored-by: Mateusz Wojczal <mateusz@wojczal.com> Co-authored-by: Maciej Rymarz <59456825+mako321@users.noreply.github.com>
EscolaLMS · May 18, 2023 · 96fbfc7 · 96fbfc7
1 parent 14b09de
commit 96fbfc7
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/src/EscolaLmsTemplatesPdfServiceProvider.php b/src/EscolaLmsTemplatesPdfServiceProvider.php
@@ -32,6 +32,10 @@ public function register()
 
         $this->app->register(AuthServiceProvider::class);
         $this->app->register(UserTemplateServiceProvider::class);
+
+        if (class_exists(\EscolaLms\Settings\Facades\AdministrableConfig::class)) {
+            AdministrableConfig::registerConfig(self::CONFIG_KEY . '.reportbro_url', ['required', 'string'], true);
+        }
     }
 
     public function boot()
@@ -42,10 +46,6 @@ public function boot()
         if ($this->app->runningInConsole()) {
             $this->bootForConsole();
         }
-
-        if (class_exists(\EscolaLms\Settings\Facades\AdministrableConfig::class)) {
-            AdministrableConfig::registerConfig(self::CONFIG_KEY . '.reportbro_url', ['required', 'string'], true);
-        }
     }
 
     public function bootForConsole()

diff --git a/src/Services/ReportBroService.php b/src/Services/ReportBroService.php
@@ -10,12 +10,10 @@
 
 class ReportBroService implements ReportBroServiceContract
 {
-
-
     public function getKeyFromPayload(string $payload): string
     {
 
-        $reportBroUrl = config(EscolaLmsTemplatesPdfServiceProvider::CONFIG_KEY . '.reportbro_url', "https://pdfs.escolalms-api-stage.s.escolait.pl/reportbro/report/run");
+        $reportBroUrl = config(EscolaLmsTemplatesPdfServiceProvider::CONFIG_KEY . '.reportbro_url');
 
         $response = Http::withBody($payload, 'application/json')
             ->send('PUT', $reportBroUrl);
@@ -27,7 +25,7 @@ public function getKeyFromPayload(string $payload): string
 
     public function getFilepathFromKey(string $key): string
     {
-        $reportBroUrl = config(EscolaLmsTemplatesPdfServiceProvider::CONFIG_KEY . '.reportbro_url', "https://pdfs.escolalms-api-stage.s.escolait.pl/reportbro/report/run");
+        $reportBroUrl = config(EscolaLmsTemplatesPdfServiceProvider::CONFIG_KEY . '.reportbro_url');
         $tempName = tempnam(sys_get_temp_dir(), 'response') . '.pdf';
 
         Http::sink($tempName)->get($reportBroUrl, ['key' => $key, 'outputFormat' => 'pdf']);

diff --git a/src/config.php b/src/config.php
@@ -1,3 +1,5 @@
 <?php
 
-return [];
+return [
+    'reportbro_url' => env('REPORTBRO_URL', "https://www.reportbro.com/report/run"),
+];
diff --git a/src/routes.php b/src/routes.php
@@ -5,6 +5,7 @@
 
 Route::group(['prefix' => 'api/pdfs'], function () {
     Route::put('/reportbro/report/run', [FabricPdfController::class, 'reportBro']);
+    Route::get('/reportbro/report/run', [FabricPdfController::class, 'reportBro']);
     Route::get('/', [FabricPdfController::class, 'index']);
     Route::get('/generate/{id}', [FabricPdfController::class, 'generate']);
     Route::get('/{id}', [FabricPdfController::class, 'show']);