Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing types #289

Open
ngirardin opened this issue Jun 14, 2023 · 2 comments
Open

Missing types #289

ngirardin opened this issue Jun 14, 2023 · 2 comments
Assignees

Comments

@ngirardin
Copy link

Hi guys,

I've identified a few missing types between the TS declarations and what the API returns:

Course

import { getCourse } from "@escolalms/sdk/lib/services/courses";

course.poster_url is missing in the types but returned by the API

lessons_count is declared but not present in the API response

author.first_name and author.last_name are missing in the types but returned by the API

Thanks!

@ngirardin
Copy link
Author

Found this one as well, the profile response is typed as DefaultResponse<any>:

Screenshot 2023-06-14 at 19 26 46

@qunabu
Copy link
Contributor

qunabu commented Jun 14, 2023

@ngirardin thanks for reporting this, we will have a look

@Haxikowy Haxikowy removed their assignment May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants